Re: [PATCH v2 4/5] dt-bindings: regulators: convert non-smd RPM Regulators bindings to dt-schema

From: Rob Herring
Date: Mon Oct 17 2022 - 15:02:53 EST


On Mon, Oct 17, 2022 at 04:47:44PM +0200, Neil Armstrong wrote:
> Hi,
>
> On 17/10/2022 16:39, Rob Herring wrote:
> > On Mon, Oct 17, 2022 at 12:23:08PM +0200, Neil Armstrong wrote:
> > > Convert the non-SMD Regulators bindings to dt-schema, the old text based
> > > bindings will be deleted later since the RPM bindings are not yet converted.
> > >
> > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > ---
> > > .../bindings/regulator/qcom,ipc-rpm-regulator.yaml | 127 +++++++++++++++++++++
> > > 1 file changed, 127 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/regulator/qcom,ipc-rpm-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,ipc-rpm-regulator.yaml
> > > new file mode 100644
> > > index 000000000000..e18bb8b87c43
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/regulator/qcom,ipc-rpm-regulator.yaml
> > > @@ -0,0 +1,127 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/regulator/qcom,ipc-rpm-regulator.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: QCOM IPC RPM REGULATOR
> >
> > Fix your capslock.
>
> It's literally taken from Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml:
>
> title: QCOM SMD RPM REGULATOR

Plenty of bad examples to follow.

Rob