Re: [PATCH v3 2/4] module: Update a comment describing what is protected by module_mutex

From: David Hildenbrand
Date: Mon Oct 17 2022 - 03:27:31 EST


On 16.10.22 14:30, Petr Pavlu wrote:
Signed-off-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
---
kernel/module/main.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/kernel/module/main.c b/kernel/module/main.c
index a12e177ea81f..5288843ca40f 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -62,10 +62,11 @@
/*
* Mutex protects:
- * 1) List of modules (also safely readable with preempt_disable),
+ * 1) list of modules (also safely readable with preempt_disable, delete and add
+ * uses RCU list operations).
* 2) module_use links,
- * 3) mod_tree.addr_min/mod_tree.addr_max.
- * (delete and add uses RCU list operations).
+ * 3) mod_tree.addr_min/mod_tree.addr_max,
+ * 4) list of unloaded_tainted_modules.
*/
DEFINE_MUTEX(module_mutex);
LIST_HEAD(modules);

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb