Re: [PATCH] dt-bindings: mfd: qcom,spmi-pmic: support rradc type

From: Krzysztof Kozlowski
Date: Sun Oct 16 2022 - 21:08:02 EST


On 16/10/2022 13:57, Caleb Connolly wrote:
> 'adc@' nodes can also be the rradc.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx>
> ---
> This patch is based on Luca's series:
> https://lore.kernel.org/linux-arm-msm/20220925211744.133947-2-luca@xxxxxxxxx/
>
> Luca: feel free to apply this as a fixup if you re-send
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index b5a06c1b67bb..cba25562e1da 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -102,6 +102,7 @@ patternProperties:
> oneOf:
> - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml#
> - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
> + - $ref: /schemas/iio/adc/qcom,spmi-rradc.yaml#

rradc seems to be present only on few specific PMICs, so we could
restrict it per compatible. Similarly like adc-tm is done.

>
> "^adc-tm@[0-9a-f]+$":
> type: object

Best regards,
Krzysztof