Re: [PATCH v3 13/14] iio: max1363: simplify using devm_regulator_get_enable()

From: Jonathan Cameron
Date: Sun Oct 16 2022 - 12:37:06 EST


On Sun, 16 Oct 2022 17:18:38 +0100
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Tue, 30 Aug 2022 11:50:05 +0000
> "Sa, Nuno" <Nuno.Sa@xxxxxxxxxx> wrote:
>
> > > -----Original Message-----
> > > From: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> > > Sent: Friday, August 19, 2022 9:21 PM
> > > To: Matti Vaittinen <mazziesaccount@xxxxxxxxx>; Matti Vaittinen
> > > <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen
> > > <lars@xxxxxxxxxx>; Matti Vaittinen <mazziesaccount@xxxxxxxxx>;
> > > Alexandru Ardelean <aardelean@xxxxxxxxxxx>; linux-
> > > iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > > Subject: [PATCH v3 13/14] iio: max1363: simplify using
> > > devm_regulator_get_enable()
> > >
> > > [External]
> > >
> > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
> > > add_action_or_reset(regulator_disable)' and use the
> > > devm_regulator_get_enable() and drop the pointer to the regulator.
> > > This simplifies code and makes it less tempting to add manual control
> > > for the regulator which is also controlled by devm.
> > >
> > > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> > >
> > > ---
> >
> > Acked-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
>
> Applied.

This one was missing cleaning up the docs as well. fixed up.