Re: [PATCH V2 1/2] net: Fixup netif_attrmask_next_and warning

From: Yury Norov
Date: Fri Oct 14 2022 - 00:43:16 EST


On Thu, Oct 13, 2022 at 08:39:11PM -0700, Jakub Kicinski wrote:
> On Thu, 13 Oct 2022 20:35:44 -0700 Jakub Kicinski wrote:
> > Can we instead revert 854701ba4c and take the larger rework Yury
> > has posted a week ago into net-next?
>
> Oh, it was reposted today:
>
> https://lore.kernel.org/all/20221013234349.1165689-2-yury.norov@xxxxxxxxx/
>
> But we need a revert of 854701ba4c as well to cover the issue back up
> for 6.1, AFAIU.

The patch 854701ba4c is technically correct. I fixed most of warnings in
advance, but nobody can foresee everything, right? I expected some noise,
and now we have just a few things to fix. This is what for -rc releases
exist, didn't they?

I suggest to keep the patch, because this is the only way to make
cpumask_check()-related issues visible to people. If things will go as
they go now, I expect that -rc3 will be clean from cpumask_check()
warnings.

Thanks,
Yury