RE: [PATCH v3 4/4] arm64: dts: fix SPI drive strength values as per FSD HW UM

From: Alim Akhtar
Date: Thu Oct 13 2022 - 21:41:59 EST




>-----Original Message-----
>From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@xxxxxxxxxxx]
>Sent: Thursday, October 13, 2022 4:10 PM
>To: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
>alim.akhtar@xxxxxxxxxxx; chanho61.park@xxxxxxxxxxx;
>linus.walleij@xxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx
>Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx; Padmanabhan Rajanbabu
><p.rajanbabu@xxxxxxxxxxx>
>Subject: [PATCH v3 4/4] arm64: dts: fix SPI drive strength values as per FSD
>HW UM
>
>Drive strength values used for SPI is not reflecting the default values
>recommended by FSD HW UM.
>
>Fix the drive strength values for SPI, thereby ensuring that the existing device
>tree file is using default drive strength values recommended by UM for FSD
>SoC.
>
>Fixes: 684dac402f21 ("arm64: dts: fsd: Add initial pinctrl support")
>Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>index a2634e70925a..e3852c946352 100644
>--- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>+++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
>@@ -323,21 +323,21 @@
> samsung,pins = "gpb4-0", "gpb4-2", "gpb4-3";
> samsung,pin-function = <FSD_PIN_FUNC_2>;
> samsung,pin-pud = <FSD_PIN_PULL_UP>;
>- samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+ samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> };
>
> spi1_bus: spi1-bus-pins {
> samsung,pins = "gpb4-4", "gpb4-6", "gpb4-7";
> samsung,pin-function = <FSD_PIN_FUNC_2>;
> samsung,pin-pud = <FSD_PIN_PULL_UP>;
>- samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+ samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> };
>
> spi2_bus: spi2-bus-pins {
> samsung,pins = "gpb5-0", "gpb5-2", "gpb5-3";
> samsung,pin-function = <FSD_PIN_FUNC_2>;
> samsung,pin-pud = <FSD_PIN_PULL_UP>;
>- samsung,pin-drv = <FSD_PIN_DRV_LV1>;
>+ samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> };
> };
>
>--
>2.17.1