Re: [PATCH v12] firmware: google: Implement cbmem in sysfs driver

From: Jack Rosenthal
Date: Thu Oct 13 2022 - 17:26:46 EST


On 2022-10-06 at 08:33 +0200, Greg KH wrote:
> On Wed, Oct 05, 2022 at 04:26:55PM -0700, Julius Werner wrote:
> > > If the kernel is reporting a value, that value needs to be documented
> > > somewhere. If the kernel is acting on that value, it needs to know what
> > > those values are.
> > >
> > > In this specific instance it seems that the kernel knows a subset of the
> > > values, and some random userspace tool knows all of them? Think about
> > > what you would want to see here if you knew nothing about this at all.
> >
> > The kernel doesn't know any of the values. The kernel is just telling
> > userspace that spaces with these IDs exist and providing an interface
> > to access them, it's not supposed to know what any of them mean.
>
> Ah, ok, that was not obvious to me, sorry. If the kernel is just a
> pass-through, no objections.

Does this mean PATCH v13 looks good to you?

thanks,

jack