Re: [PATCH v7 net-next 4/9] net: switchdev: support offloading of the FDB blackhole flag

From: Ido Schimmel
Date: Thu Oct 13 2022 - 10:21:50 EST


On Sun, Oct 09, 2022 at 07:40:47PM +0200, Hans J. Schultz wrote:
> Add support for offloading of the FDB blackhole flag.
>
> Signed-off-by: Hans J. Schultz <netdev@xxxxxxxxxxxxxxxxxxxx>
> ---
> include/net/dsa.h | 1 +
> include/net/switchdev.h | 1 +
> net/bridge/br.c | 3 ++-
> net/bridge/br_fdb.c | 19 ++++++++++++++++---
> net/bridge/br_private.h | 3 ++-
> net/bridge/br_switchdev.c | 1 +
> net/dsa/dsa_priv.h | 4 ++--
> net/dsa/port.c | 22 ++++++++++++----------
> net/dsa/slave.c | 6 ++++--
> 9 files changed, 41 insertions(+), 19 deletions(-)

Too many changes at once. I suggest to split into:

1. A patch that allows the bridge driver to be notified about blackhole
entries from device drivers and also notifying it to drivers when added
from user space. These changes:

include/net/switchdev.h | 1 +
net/bridge/br.c | 3 ++-
net/bridge/br_fdb.c | 19 ++++++++++++++++---
net/bridge/br_private.h | 3 ++-
net/bridge/br_switchdev.c | 1 +

2. The DSA changes