Re: [PATCH 4/7] gpiolib: of: add a quirk for reset line for Marvell NFC controller

From: Dmitry Torokhov
Date: Wed Oct 12 2022 - 14:45:13 EST


On Wed, Oct 12, 2022 at 11:29:02AM +0100, Daniel Thompson wrote:
> On Tue, Oct 11, 2022 at 03:19:32PM -0700, Dmitry Torokhov wrote:
> > The controller is using non-standard "reset-n-io" name for its reset
> > gpio property, whereas gpiod API expects "<name>-gpios". Add a quirk
> > so that gpiod API will still work on unmodified DTSes.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> How/when has/will the DT bindings documentation for this hardware be
> updated to describe the new bindings?
>
> Delivering the quirks ahead of driver updates is great for avoiding
> merge conflicts but it also conceals the rename from reviewers so
> risks neglecting to update the bindings.

I was planning on sending binding updates once driver patches land.

>
> Other than that:
> Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

Thank you for your reviews!

--
Dmitry