Re: [PATCH] ext4: Add extend check to prevent BUG() in ext4_es_end

From: Tadeusz Struk
Date: Tue Oct 11 2022 - 14:38:46 EST


On 9/30/22 13:25, Tadeusz Struk wrote:
Syzbot reported an issue with ext4 extents. The reproducer creates
a corrupted ext4 fs image in memory, and mounts it as a loop device.
It invokes the ext4_cache_extents() and ext4_find_extent(), which
eventually triggers a BUG() in ext4_es_end() causing a kernel crash.
It triggers on mainline, and every kernel version back to v4.14.
Add a call ext4_ext_check_inode() in ext4_find_extent() to prevent
the crash.

To: "Theodore Ts'o"<tytso@xxxxxxx>
Cc: "Andreas Dilger"<adilger.kernel@xxxxxxxxx>
Cc:<linux-ext4@xxxxxxxxxxxxxxx>
Cc:<linux-kernel@xxxxxxxxxxxxxxx>
Cc:<stable@xxxxxxxxxxxxxxx>

Link:https://syzkaller.appspot.com/bug?id=641e7a4b900015c5d7a729d6cc1fba7a928a88f9
Reported-by:syzbot+a22dc4b0744ac658ed9b@xxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Tadeusz Struk<tadeusz.struk@xxxxxxxxxx>

Hi,
Any comments/feedback on this one?

--
Thanks,
Tadeusz