Re: [RFC PATCH] Remove Intel compiler support

From: Masahiro Yamada
Date: Tue Oct 11 2022 - 13:03:50 EST


On Wed, Oct 12, 2022 at 1:52 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Tue, Oct 11, 2022 at 8:55 PM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> >
> > On Tue, Oct 11, 2022 at 5:19 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> > >
> > > include/linux/compiler-intel.h | 34 -----
> > > include/linux/compiler_types.h | 2 -
> >
> > You can also remove a few lines from `compiler_attributes.h`:
> >
> > * Optional: not supported by icc
> >
> > Thanks for this!
> >
> > Cheers,
> > Miguel
>
>
>
> Thanks.
>
>
> Maybe, we can drop #if ... #else ... #endif
> around __assume_aligned(a, ...), but I will leave it to you.
>
>
> I will just drop the comment lines for now.
> (Then, you will clean up compiler_attributes.h in the next cycle)
> Is this your expectation for v2 ?


Taking a look at the code, there is only one redundant #if.
So, I will clean up __assume_aligned() in v2.








--
Best Regards
Masahiro Yamada