Re: [PATCH v6 4/7] treewide: use get_random_{u8,u16}() when possible, part 2

From: Heiko Carstens
Date: Tue Oct 11 2022 - 06:01:45 EST


On Mon, Oct 10, 2022 at 05:06:10PM -0600, Jason A. Donenfeld wrote:
> Rather than truncate a 32-bit value to a 16-bit value or an 8-bit value,
> simply use the get_random_{u8,u16}() functions, which are faster than
> wasting the additional bytes from a 32-bit value. This was done by hand,
> identifying all of the places where one of the random integer functions
> was used in a non-32-bit context.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Reviewed-by: Yury Norov <yury.norov@xxxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> ---
> arch/s390/kernel/process.c | 2 +-

For s390:
Acked-by: Heiko Carstens <hca@xxxxxxxxxxxxx>