Re: [PATCH v6 1/7] treewide: use prandom_u32_max() when possible, part 1

From: Heiko Carstens
Date: Tue Oct 11 2022 - 06:00:29 EST


On Mon, Oct 10, 2022 at 05:06:07PM -0600, Jason A. Donenfeld wrote:
> Rather than incurring a division or requesting too many random bytes for
> the given range, use the prandom_u32_max() function, which only takes
> the minimum required bytes from the RNG and avoids divisions. This was
...
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Reviewed-by: Yury Norov <yury.norov@xxxxxxxxx>
> Reviewed-by: KP Singh <kpsingh@xxxxxxxxxx>
> Reviewed-by: Jan Kara <jack@xxxxxxx> # for ext4 and sbitmap
> Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx> # for drbd
> Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> # for mmc
> Acked-by: Darrick J. Wong <djwong@xxxxxxxxxx> # for xfs
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> ---
> arch/s390/kernel/process.c | 2 +-
> arch/s390/kernel/vdso.c | 2 +-

For s390:
Acked-by: Heiko Carstens <hca@xxxxxxxxxxxxx>