Re: [net PATCH 1/2] net: dsa: qca8k: fix inband mgmt for big-endian systems

From: Andrew Lunn
Date: Mon Oct 10 2022 - 14:53:19 EST


> /* Special struct emulating a Ethernet header */
> struct qca_mgmt_ethhdr {
> - u32 command; /* command bit 31:0 */
> - u32 seq; /* seq 63:32 */
> - u32 mdio_data; /* first 4byte mdio */
> + __le32 command; /* command bit 31:0 */
> + __le32 seq; /* seq 63:32 */
> + __le32 mdio_data; /* first 4byte mdio */
> __be16 hdr; /* qca hdr */
> } __packed;

It looks odd that hdr is BE while the rest are LE. Did you check this?

Andrew