Re: [PATCH] cgroup: Fix crash with CLONE_INTO_CGROUP and v1 cgroups

From: Tejun Heo
Date: Mon Oct 10 2022 - 14:49:21 EST


On Sun, Oct 09, 2022 at 08:16:29PM +0200, Greg KH wrote:
> On Sun, Oct 09, 2022 at 07:35:19PM +0200, Christian Brauner wrote:
> > On Sun, Oct 09, 2022 at 03:10:36PM +0200, Christian A. Ehrhardt wrote:
> > >
> > > Since commit f3a2aebdd6, Version 1 cgroups no longer cause an
> > > error when used with CLONE_INTO_CGROUP. However, the permission
> > > checks performed during clone assume a Version 2 cgroup.
> > >
> > > Restore the error check for V1 cgroups in the clone() path.
> > >
> > > Reported-by: syzbot+534ee3d24c37c411f37f@xxxxxxxxxxxxxxxxxxxxxxxxx
> > > Link: https://lore.kernel.org/lkml/000000000000385cbf05ea3f1862@xxxxxxxxxx/
> > > Fixes: f3a2aebdd6 ("cgroup: enable cgroup_get_from_file() on cgroup1")
> > > Signed-off-by: Christian A. Ehrhardt <lk@xxxxxxx>
> > > ---
> >
> > Thanks for fixing this,
> > Reviewed-by: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx>
>
> No cc: stable? :(

This got merged this cycle, so no need for -stable.

Thanks.

--
tejun