RE: [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link()

From: Soha Jin
Date: Mon Oct 10 2022 - 11:44:53 EST


Hello Andrew,

> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Monday, October 10, 2022 11:03 PM
>
> On Mon, Oct 10, 2022 at 12:20:06AM +0800, Soha Jin wrote:
> > A helper function to check if PHY is fixed link with fwnode properties.
> > This is similar to of_phy_is_fixed_link.
>
> You need to include a user of this new function.

Greg already notified me about this. I was thinking this patch and my
driver patches are on different trees, so I split the patches into
different parts. I will include this patch in my driver patch's v2 later
and ask you to review then. Sorry for the mistake.

> Also, not that ACPI only defines the 'new binding' for fixed-link. If this is
> being called on a device which is ACPI underneath, it should only return true
> for the 'new binding', not the old binding.

Thanks for the information, I will correct this.

Regards,
Soha