RE: [PATCH -next] i2c: mlxbf: Fix unused-variable warning

From: Asmaa Mnebhi
Date: Mon Oct 10 2022 - 08:00:41 EST


Acked-by: Asmaa Mnebhi

-----Original Message-----
From: Ren Zhijie <renzhijie2@xxxxxxxxxx>
Sent: Sunday, October 9, 2022 9:38 AM
To: Khalil Blaiech <kblaiech@xxxxxxxxxx>; Asmaa Mnebhi <asmaa@xxxxxxxxxx>; Vadim Pasternak <vadimp@xxxxxxxxxx>; wsa@xxxxxxxxxx
Cc: linux-i2c@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Ren Zhijie <renzhijie2@xxxxxxxxxx>
Subject: [PATCH -next] i2c: mlxbf: Fix unused-variable warning

If CONFIG_ACPI is not set,
gcc warns about unused variable:

drivers/i2c/busses/i2c-mlxbf.c:2206:35: error: ‘mlxbf_i2c_chip’ defined but not used [-Werror=unused-variable] static struct mlxbf_i2c_chip_info mlxbf_i2c_chip[] = {
^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Mark these variables as __maybe_unused to fix this.

Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: Ren Zhijie <renzhijie2@xxxxxxxxxx>
---
drivers/i2c/busses/i2c-mlxbf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c index e68e775f187e..087df1a53797 100644
--- a/drivers/i2c/busses/i2c-mlxbf.c
+++ b/drivers/i2c/busses/i2c-mlxbf.c
@@ -2203,7 +2203,7 @@ static u32 mlxbf_i2c_functionality(struct i2c_adapter *adap)
return MLXBF_I2C_FUNC_ALL;
}

-static struct mlxbf_i2c_chip_info mlxbf_i2c_chip[] = {
+static struct mlxbf_i2c_chip_info __maybe_unused mlxbf_i2c_chip[] = {
[MLXBF_I2C_CHIP_TYPE_1] = {
.type = MLXBF_I2C_CHIP_TYPE_1,
.shared_res = {
--
2.17.1