Re: [PATCH 1/2] mtd: spinand: winbond: fix winbond lashes identifications

From: Frieder Schrempf
Date: Mon Oct 10 2022 - 03:28:59 EST


On 07.10.22 12:48, mikhail.kshevetskiy@xxxxxxxxx wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@xxxxxxxxx>
>
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)

^ identification

> is identified as W25N01GV (id_bytes: EF, AA, 21).
>
> Fix this by adding missed identification bytes.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@xxxxxxxxx>

Two things:

* each time you send a new version of your patches, you should increase
the version number in the prefix (e. g. using "git format-patch -v 2").

* I'm not a native English speaker and I don't get what "fix winbond
lashes identifications" is supposed to mean. Maybe something simple like
"fix identification" or "add missing id bytes" would do?