Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency

[Ren Zhijie]

Hi,

just a friendly ping...

Ren

在 2022/9/22 17:58, ChiaEn Wu 写道:
> On 9/22/2022 10:33 AM, Ren Zhijie wrote:
> > If CONFIG_IIO is not set,
> > make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
> > will be failed, like this:
> >
> > drivers/power/supply/mt6370-charger.o: In function 
> > `mt6370_chg_mivr_dwork_func':
> > mt6370-charger.c:(.text+0x670): undefined reference to 
> > `iio_read_channel_processed'
> > drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_probe':
> > mt6370-charger.c:(.text+0xb43): undefined reference to 
> > `devm_iio_channel_get_all'
> > make: *** [vmlinux] Error 1
> >
> > To fix this build error, add depends on IIO to config CHARGER_MT6370 
> > dependency.
> >
> > Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 
> > charger driver")
> > Signed-off-by: Ren Zhijie <renzhijie2@xxxxxxxxxx>
> > ---
> >   drivers/power/supply/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> > index 591deb82e2c6..62111f4bb093 100644
> > --- a/drivers/power/supply/Kconfig
> > +++ b/drivers/power/supply/Kconfig
> > @@ -623,6 +623,7 @@ config CHARGER_MT6370
> >       tristate "MediaTek MT6370 Charger Driver"
> >       depends on MFD_MT6370
> >       depends on REGULATOR
> > +    depends on IIO
> >       select LINEAR_RANGES
> >       help
> >         Say Y here to enable MT6370 Charger Part.
>
> Hi Ren,
>
> Thanks for catching this!
>
> Reviewed-by: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx>