Re: [PATCH 5/6] x86/gsseg: move load_gs_index() to its own header file

From: H. Peter Anvin
Date: Fri Oct 07 2022 - 13:44:12 EST


On October 7, 2022 8:40:41 AM PDT, Brian Gerst <brgerst@xxxxxxxxx> wrote:
>On Thu, Oct 6, 2022 at 12:13 PM Xin Li <xin3.li@xxxxxxxxx> wrote:
>>
>> From: "H. Peter Anvin (Intel)" <hpa@xxxxxxxxx>
>>
>> <asm/cpufeature.h> depends on <asm/special_insns.h>, so in order to be
>> able to use alternatives in native_load_gs_index(), factor it out into
>> a separate header file.
>>
>> Signed-off-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>
>> Signed-off-by: Xin Li <xin3.li@xxxxxxxxx>
>
>This could be moved into <asm/segment.h> instead of creating a new header file.
>
>--
>Brian Gerst

At least at the time I wrote the code, it could not, without creating yet another circular header file dependency.