Re: [PATCH v2 12/16] dt-bindings: pinctrl: qcom,sm8250: drop checks used in common TLMM

From: Bjorn Andersson
Date: Thu Oct 06 2022 - 23:16:17 EST


On Fri, Sep 30, 2022 at 09:29:50PM +0200, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema brings already
> requirement of function for gpio pins.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>

> ---
> .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> index d7d8e5d3b659..021592b32904 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
> @@ -64,6 +64,7 @@ patternProperties:
> if:
> type: object
> then:
> + $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
> properties:
> pins:
> description:
> @@ -118,16 +119,6 @@ patternProperties:
> required:
> - pins
>
> - allOf:
> - - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
> - - if:
> - properties:
> - pins:
> - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$"
> - then:
> - required:
> - - function
> -
> additionalProperties: false
>
> allOf:
> --
> 2.34.1
>