Re: [syzbot] memory leak in __get_metapage

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in __get_metapage

BUG: memory leak
unreferenced object 0xffff88810abfae80 (size 128):
  comm "syz-executor.0", pid 4206, jiffies 4294944336 (age 14.270s)
  hex dump (first 32 bytes):
    00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff8148f863>] mempool_alloc+0x73/0x230 mm/mempool.c:392
    [<ffffffff81c5adba>] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline]
    [<ffffffff81c5adba>] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651
    [<ffffffff81c43722>] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265
    [<ffffffff81c45114>] diAllocExt fs/jfs/jfs_imap.c:1945 [inline]
    [<ffffffff81c45114>] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662
    [<ffffffff81c46f3f>] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583
    [<ffffffff81c57c5a>] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56
    [<ffffffff81c3a397>] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225
    [<ffffffff815f9a23>] vfs_mkdir+0x223/0x340 fs/namei.c:4013
    [<ffffffff81602a05>] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038
    [<ffffffff81602b79>] __do_sys_mkdir fs/namei.c:4058 [inline]
    [<ffffffff81602b79>] __se_sys_mkdir fs/namei.c:4056 [inline]
    [<ffffffff81602b79>] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056
    [<ffffffff846099a5>] do_syscall_x64 arch/x86/entry/common.c:50 [inline]
    [<ffffffff846099a5>] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
    [<ffffffff84800087>] entry_SYSCALL_64_after_hwframe+0x63/0xcd

BUG: memory leak
unreferenced object 0xffff88810abfaf00 (size 128):
  comm "syz-executor.0", pid 4206, jiffies 4294944336 (age 14.270s)
  hex dump (first 32 bytes):
    00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff8148f863>] mempool_alloc+0x73/0x230 mm/mempool.c:392
    [<ffffffff81c5adba>] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline]
    [<ffffffff81c5adba>] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651
    [<ffffffff81c43722>] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265
    [<ffffffff81c45114>] diAllocExt fs/jfs/jfs_imap.c:1945 [inline]
    [<ffffffff81c45114>] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662
    [<ffffffff81c46f3f>] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583
    [<ffffffff81c57c5a>] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56
    [<ffffffff81c3a397>] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225
    [<ffffffff815f9a23>] vfs_mkdir+0x223/0x340 fs/namei.c:4013
    [<ffffffff81602a05>] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038
    [<ffffffff81602b79>] __do_sys_mkdir fs/namei.c:4058 [inline]
    [<ffffffff81602b79>] __se_sys_mkdir fs/namei.c:4056 [inline]
    [<ffffffff81602b79>] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056
    [<ffffffff846099a5>] do_syscall_x64 arch/x86/entry/common.c:50 [inline]
    [<ffffffff846099a5>] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
    [<ffffffff84800087>] entry_SYSCALL_64_after_hwframe+0x63/0xcd

BUG: memory leak
unreferenced object 0xffff88810a5a7080 (size 128):
  comm "syz-executor.0", pid 4206, jiffies 4294944336 (age 14.270s)
  hex dump (first 32 bytes):
    00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff8148f863>] mempool_alloc+0x73/0x230 mm/mempool.c:392
    [<ffffffff81c5adba>] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline]
    [<ffffffff81c5adba>] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651
    [<ffffffff81c43722>] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265
    [<ffffffff81c45114>] diAllocExt fs/jfs/jfs_imap.c:1945 [inline]
    [<ffffffff81c45114>] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662
    [<ffffffff81c46f3f>] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583
    [<ffffffff81c57c5a>] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56
    [<ffffffff81c3a397>] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225
    [<ffffffff815f9a23>] vfs_mkdir+0x223/0x340 fs/namei.c:4013
    [<ffffffff81602a05>] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038
    [<ffffffff81602b79>] __do_sys_mkdir fs/namei.c:4058 [inline]
    [<ffffffff81602b79>] __se_sys_mkdir fs/namei.c:4056 [inline]
    [<ffffffff81602b79>] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056
    [<ffffffff846099a5>] do_syscall_x64 arch/x86/entry/common.c:50 [inline]
    [<ffffffff846099a5>] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
    [<ffffffff84800087>] entry_SYSCALL_64_after_hwframe+0x63/0xcd

BUG: memory leak
unreferenced object 0xffff888114d44e80 (size 128):
  comm "syz-executor.0", pid 4734, jiffies 4294944949 (age 8.140s)
  hex dump (first 32 bytes):
    00 10 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff8148f863>] mempool_alloc+0x73/0x230 mm/mempool.c:392
    [<ffffffff81c5adba>] alloc_metapage fs/jfs/jfs_metapage.c:176 [inline]
    [<ffffffff81c5adba>] __get_metapage+0x38a/0x9b0 fs/jfs/jfs_metapage.c:651
    [<ffffffff81c43722>] diNewExt+0x3f2/0x9d0 fs/jfs/jfs_imap.c:2265
    [<ffffffff81c45114>] diAllocExt fs/jfs/jfs_imap.c:1945 [inline]
    [<ffffffff81c45114>] diAllocAG+0x9a4/0xd50 fs/jfs/jfs_imap.c:1662
    [<ffffffff81c46f3f>] diAlloc+0x31f/0x900 fs/jfs/jfs_imap.c:1583
    [<ffffffff81c57c5a>] ialloc+0x6a/0x3a0 fs/jfs/jfs_inode.c:56
    [<ffffffff81c3a397>] jfs_mkdir+0xf7/0x480 fs/jfs/namei.c:225
    [<ffffffff815f9a23>] vfs_mkdir+0x223/0x340 fs/namei.c:4013
    [<ffffffff81602a05>] do_mkdirat+0x1a5/0x1e0 fs/namei.c:4038
    [<ffffffff81602b79>] __do_sys_mkdir fs/namei.c:4058 [inline]
    [<ffffffff81602b79>] __se_sys_mkdir fs/namei.c:4056 [inline]
    [<ffffffff81602b79>] __x64_sys_mkdir+0x69/0x90 fs/namei.c:4056
    [<ffffffff846099a5>] do_syscall_x64 arch/x86/entry/common.c:50 [inline]
    [<ffffffff846099a5>] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
    [<ffffffff84800087>] entry_SYSCALL_64_after_hwframe+0x63/0xcd



Tested on:

commit:         ffb39098 Merge tag 'linux-kselftest-kunit-6.1-rc1' of ..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14c99b0a880000
kernel config:  https://syzkaller.appspot.com/x/.config?x=10f41fbb818af57a
dashboard link: https://syzkaller.appspot.com/bug?extid=389b82b29093b3e2640a
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.