Re: [PATCH 00/34] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings (5th set)

From: Stephan Gerhold
Date: Thu Oct 06 2022 - 11:49:46 EST


Hi Krzysztof,

On Thu, Oct 06, 2022 at 04:06:03PM +0200, Krzysztof Kozlowski wrote:
> [...]
> Krzysztof Kozlowski (34):
> dt-bindings: pinctrl: qcom,mdm9607: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sc7280: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sc8180x: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sc8180x: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sc8280xp: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm6115: use common TLMM schema
> dt-bindings: pinctrl: qcom,sm6125: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm6125: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm6350: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm6350: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm6375-tlmm: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm6375-tlmm: drop checks used in common
> TLMM
> dt-bindings: pinctrl: qcom,sm8250: use common TLMM schema
> dt-bindings: pinctrl: qcom,sm8350: drop ref to pinctrl.yaml
> dt-bindings: pinctrl: qcom,sm8350: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,sm8450: drop checks used in common TLMM
> dt-bindings: pinctrl: qcom,mdm9607: minor style cleanups
> dt-bindings: pinctrl: qcom,msm8909-tlmm: minor style cleanups
> dt-bindings: pinctrl: qcom,qcm2290: minor style cleanups
> dt-bindings: pinctrl: qcom,sdx65: minor style cleanups
> dt-bindings: pinctrl: qcom,sc8180x: minor style cleanups
> dt-bindings: pinctrl: qcom,sc8280xp: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6115: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6125: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6350: minor style cleanups
> dt-bindings: pinctrl: qcom,sm6375: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8250: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8350: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8450: minor style cleanups
> dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: minor style cleanups
> dt-bindings: pinctrl: qcom: adjust description
>
> .../pinctrl/qcom,ipq6018-pinctrl.yaml | 5 +-
> .../pinctrl/qcom,mdm9607-pinctrl.yaml | 16 ++---
> .../pinctrl/qcom,msm8226-pinctrl.yaml | 5 +-
> .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 11 ++-
> .../pinctrl/qcom,msm8953-pinctrl.yaml | 5 +-
> .../pinctrl/qcom,qcm2290-pinctrl.yaml | 10 ++-
> .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 13 ++--
> .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 16 +----
> .../pinctrl/qcom,sc8180x-pinctrl.yaml | 27 +++----
> .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 13 ++--
> .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 22 ++----
> .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 +-
> .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 10 ++-
> .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 53 +++-----------
> .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 30 +++-----
> .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 23 ++----
> .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 23 ++----
> .../qcom,sm8250-lpass-lpi-pinctrl.yaml | 16 ++---
> .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 70 ++++++-------------
> .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 23 ++----
> .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++--
> .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 22 ++----

Just a random thought since you are already doing minor style cleanups
here: Some of these files are named incorrectly, e.g. qcom,sm8450-pinctrl.yaml
actually documents "qcom,sm8450-tlmm". I noticed this while adding
qcom,msm8909-tlmm but I have to admit that it did not bother me enough
to actually prepare a patch for this (and now it would just conflict
with all your patches). :)

No need to change anything here, just thought I'd mention it.

Thanks!
Stephan