Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0

From: Damien Le Moal
Date: Thu Oct 06 2022 - 04:43:20 EST


On 10/6/22 17:37, Sergey Shtylyov wrote:
> Hello!
>
> Perhaps s/by/with/ in the subject?

I can fix that when applying.

>
> On 10/6/22 8:17 AM, Christophe Leroy wrote:
>
>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>
>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>
>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>
>> So use 0 instead of using NO_IRQ.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>
> [...]
>
> MBR, Sergey

--
Damien Le Moal
Western Digital Research