Re: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

From: Krzysztof Kozlowski
Date: Thu Oct 06 2022 - 04:17:05 EST


On 06/10/2022 04:04, allen wrote:
> From: allen chen <allen.chen@xxxxxxxxxx>
>
> Add properties to restrict dp output data-lanes and clock.
>
> Signed-off-by: Pin-Yen Lin <treapking@xxxxxxxxxxxx>
> Signed-off-by: Allen Chen <allen.chen@xxxxxxxxxx>
> ---
> .../bindings/display/bridge/ite,it6505.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a..f5482a614d05 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,6 +52,16 @@ properties:
> maxItems: 1
> description: extcon specifier for the Power Delivery
>
> + ite,dp-output-data-lane-count:
> + description: restrict the dp output data-lanes with value of 1-4

Drop "with value of 1-4" because it is redundant, but instead explain
what this property is about. "Restrict output" is not yet enough.
Restrict the number? Or choose specific lanes? Why it cannot be
data-lanes from video-interfaces?

> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 1, 2, 4 ]
> +
> + ite,dp-output-max-pixel-clock-mhz:

Test your patches before sending.

Best regards,
Krzysztof