Re: [PATCH v5 1/2] arm64: dts: qcom: sagit: add initial device tree for sagit

From: Krzysztof Kozlowski
Date: Tue Oct 04 2022 - 07:12:53 EST


On 03/10/2022 21:43, Dzmitry Sankouski wrote:
> New device support - Xiaomi Mi6 phone
>
> What works:
> - storage
> - usb
> - power regulators
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
> ---
> Changes for v5:
> - use pm8005_regulators label

It's the third patch sent right after another. No. You need to wait one
day. More over, all previous changelog is gone, so I really have no clue
what is happening here.

Send v6 with proper changelogs and all comments applied or keep
discussing. You keep ignoring comments, then resending something three
times. It's not the way to work with reviewers and make their life easier.

> +
> + wcd_int_n: wcd-int-n {
> + pins = "gpio54";
> + function = "gpio";
> + bias-pull-down;
> + drive-strength = <2>;
> + input-enable;
> + };
> +
> + wsa_leftspk_pwr_n: wsa-leftspk-pwr-n {
> + pins = "gpio65";
> + function = "gpio";

Still wrong.

Best regards,
Krzysztof