Re: [PATCH] HID: alps: Simplify the .remove function

From: Christophe JAILLET
Date: Mon Oct 03 2022 - 15:17:07 EST


Le 03/10/2022 à 17:40, Marcus Folkesson a écrit :
Hi Christophe!

On Sun, Oct 02, 2022 at 04:38:26PM +0200, Christophe JAILLET wrote:
If the .remove function of a 'hid_driver' is NULL, the default behavior is
to call hid_hw_stop().

So alps_remove() can be removed here, it is just hand-writing what
already exists.

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---


There is already a patch out there :-)

Great,

But I always find it funny when something that is there since many years (819d64e51d62 - 2016-06-23) is fixed twice in a row from unrelated work!

CJ


https://lore.kernel.org/all/20220915123438.520775-1-marcus.folkesson@xxxxxxxxx/

Best regards,
Marcus Folkesson