Re: [PATCH v2 2/2] media: platform: mtk-mdp3: fix error handling about components clock_on

From: AngeloGioacchino Del Regno
Date: Mon Oct 03 2022 - 08:37:31 EST

Next message: Frederic Weisbecker: "Re: [PATCH RFC v2 rcu 3/8] srcu: Check for consistent per-CPU per-srcu_struct NMI safety"
Previous message: Jean Delvare: "[PATCH] drm/display: Drop obsolete dependency on COMPILE_TEST"
In reply to: Moudy Ho: "[PATCH v2 2/2] media: platform: mtk-mdp3: fix error handling about components clock_on"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Il 03/10/22 09:08, Moudy Ho ha scritto:

Add goto statement in mdp_comp_clock_on() to avoid error code not being
propagated or returning positive values.
This change also performs a well-timed clock_off when an error occurs, and
reduces unnecessary error logging in mdp_cmdq_send().

Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Next message: Frederic Weisbecker: "Re: [PATCH RFC v2 rcu 3/8] srcu: Check for consistent per-CPU per-srcu_struct NMI safety"
Previous message: Jean Delvare: "[PATCH] drm/display: Drop obsolete dependency on COMPILE_TEST"
In reply to: Moudy Ho: "[PATCH v2 2/2] media: platform: mtk-mdp3: fix error handling about components clock_on"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]