Re: [PATCH] arm64: dts: rockchip: add BT/wifi nodes to Pinephone Pro

From: Tom Fitzhenry
Date: Sun Oct 02 2022 - 05:35:27 EST


Hi Caleb and Heiko,

Thank you for your reviews.

On 7/9/22 18:26, Heiko Stübner wrote:
+ /* Power sequence for SDIO WiFi module */

This comment isn't needed, instead give the node a better name/label
+ sdio_pwrseq: sdio-pwrseq {

wifi_pwrseq: sdio-pwrseq-wifi {

I guess, I'd move the components around a tiny bit and go with

wifi_pwrseq: sdio-wifi-pwrseq {

So far everywhere the "-pwrseq" is at the end and while I don't
think that this is enforced (yet), keeping some sort of consistency
might be nice :-)

Done. I have applied this in v2.