Re: [PATCH v2 3/3] iio: adc: twl4030-madc: add missing of.h include

From: Dmitry Torokhov
Date: Sat Oct 01 2022 - 18:14:19 EST


On Sat, Oct 01, 2022 at 06:07:05PM +0100, Jonathan Cameron wrote:
> On Tue, 27 Sep 2022 19:20:00 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > On Tue, Sep 27, 2022 at 08:46:11AM -0700, Dmitry Torokhov wrote:
> > > The driver is using of_device_id/of_match_ptr() and therefore needs
> > > to include of.h header. We used to get this definition indirectly via
> > > inclusion of matrix_keypad.h from twl.h, but we are cleaning up
> > > matrix_keypad.h from unnecessary includes.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Applied to the togreg branch of iio.git and pushed out as testing for
> 0-day to take a look.
>
> Note that this is 6.2 material now - if that's an issue for the matrix_keypad.h
> cleanup then feel free to take it via the input tree with
> Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> but shout in reply to this so I know to drop it from the iio tree.

OK, it is not urgent, but I do not want to lose matrix keypad changes...

How about I'll wait to see where the rest of the patches end, and if
they end up in 6.1 I'll queue twl4030-madc.c through my tree together
with the header change?

Thanks.

--
Dmitry