Re: [PATCH 3/4] kunit: eliminate KUNIT_INIT_*_ASSERT_STRUCT macros

From: Daniel Latypov
Date: Sat Oct 01 2022 - 13:48:52 EST


On Sat, Oct 1, 2022 at 3:12 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Sat, Oct 1, 2022 at 2:26 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote:
> >
> > But we can work around this with the following generic macro
> > #define KUNIT_INIT_ASSERT(initializers...) { initializers }
>
> Is it intended to be internal, right? Should be prefixed by `_` then?

Yeah, 100% internal.

We don't have such a convention in KUnit yet, see the discussion in
https://lore.kernel.org/linux-kselftest/CABVgOSmcheQvBRKqc-0ftmbthx=EReoQ-910QV0QMNuxLWjTUQ@xxxxxxxxxxxxxx/T/#u
I'd be personally fine with _s, but this patch just tried to keep
things consistent with what was there before.

Daniel