RE: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers

[Shenwei Wang]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Friday, September 30, 2022 3:05 PM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>
> Cc: David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann
> <daniel@xxxxxxxxxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John
> Fastabend <john.fastabend@xxxxxxxxx>; Wei Fang <wei.fang@xxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH 1/1] net: fec: using page pool to manage RX buffers
> 
> Caution: EXT Email
> 
> > -static bool fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> > -                            struct bufdesc *bdp, u32 length, bool swap)
> > +static bool __maybe_unused
> > +fec_enet_copybreak(struct net_device *ndev, struct sk_buff **skb,
> > +                struct bufdesc *bdp, u32 length, bool swap)
> >  {
> 
> Why add __maybe_unused? If its not used, remove it. We don't leave dead
> functions in the code.
> 

I was thinking to remove them by a separate patch once the page pool solution is accepted.

Regards,
Shenwei

>      Andrew