Re: [PATCH 2/3] arm64: dts: qcom: sdm850-samsung-w737: correct I2C12 pins drive strength

From: Konrad Dybcio
Date: Fri Sep 30 2022 - 15:42:00 EST




On 30.09.2022 21:20, Krzysztof Kozlowski wrote:
> The pin configuration (done with generic pin controller helpers and
> as expressed by bindings) requires children nodes with either:
> 1. "pins" property and the actual configuration,
> 2. another set of nodes with above point.
>
> The qup_i2c12_default pin configuration used second method - with a
> "pinmux" child.
>
> Fixes: d4b341269efb ("arm64: dts: qcom: Add support for Samsung Galaxy Book2")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> index f954fe5cb61a..d028a7eb364a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
> @@ -415,8 +415,10 @@ pinconf {
> };
>
> &qup_i2c12_default {
> - drive-strength = <2>;
> - bias-disable;
> + pinmux {
> + drive-strength = <2>;
> + bias-disable;
> + };
> };
>
> &qup_uart6_default {