Re: [PATCH v6 net-next 0/9] Extend locked port feature with FDB locked flag (MAC-Auth/MAB)

From: netdev
Date: Fri Sep 30 2022 - 11:01:50 EST


On 2022-09-30 16:05, Ido Schimmel wrote:
On Fri, Sep 30, 2022 at 07:42:37AM +0200, netdev@xxxxxxxxxxxxxxxxxxxx wrote:
Obviously my method of selecting all switchcore drivers with sub-options
under menuconfig was not sufficient, and I didn't know of the allmodconfig
option, otherwise I would have used it.

You can see build issues on patchwork:

https://patchwork.kernel.org/project/netdevbpf/patch/20220928150256.115248-6-netdev@xxxxxxxxxxxxxxxxxxxx/

Also:

https://docs.kernel.org/next/process/maintainer-netdev.html#what-level-of-testing-is-expected-before-i-submit-my-change

https://docs.kernel.org/next/process/maintainer-netdev.html#can-i-reproduce-the-checks-from-patchwork-on-my-local-machine

https://docs.kernel.org/next/process/maintainer-netdev.html#running-all-the-builds-and-checks-locally-is-a-pain-can-i-post-my-patches-and-have-the-patchwork-bot-validate-them

So the question is if I should repost the fixed patch-set or I need to make
a new version?

A new fixed version (v7) is required, but wait for this version to be
reviewed first.

Anyhow I hope that there will not be problems when running the selftests, as
I have not been able to do so with my system, so there can be more that
needs to be changed.

It's not really acceptable to post tests that you haven't run... What
exactly is the issue? You should be able to run the tests with veth
pairs in a VM.

It is only the blackhole test that I have not been able to run as is, but I have stepped it manually as far as I could.
My environment has changed lately and in that context the building of the selftests fails and I don't know why,I just get some error messagesabout missing header files, and setting up a whole system like f.ex. linuxfromscratch with the necessary libs and tools to run it in a VM is too time consuming a task at the moment.

If there is some freely available system for the purpose out there besides my own system based on Buildroot that does not work now, please let me know...