Re: [PATCH] i2c: i801: Prefer async probe

From: Jarkko Nikula
Date: Fri Sep 30 2022 - 06:40:48 EST


On 9/29/22 18:43, Jean Delvare wrote:
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index a176296f4fff..e06509edc5f3 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1838,6 +1838,7 @@ static struct pci_driver i801_driver = {
.shutdown = i801_shutdown,
.driver = {
.pm = &i801_pm_ops,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
};

Seems reasonable. I can't foresee any problem that would occur from
this change, and preliminary testing on my own workstation is OK.

Jarkko, Heiner, Wolfram, can you think of any reason why we should NOT
apply this change?

I tested this on two systems. One with EE1004-compliant SPD EEPROM and another with touchpad connected to RMI4 SMB bus.

Average boot time improved ~20 ms over 5 boots on the first system and did not see any issue with the touchpad on second.

Tested-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>