[PATCH v3] x86/mm/tlb: update some comments in pte_flags_need_flush

From: Xin Hao
Date: Thu Sep 29 2022 - 22:24:53 EST


There just changed the comment about 'flush_on_clear' check, which make
the explanation more reasonable.

Suggested-by: Nadav Amit <namit@xxxxxxxxxx>
Suggested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Signed-off-by: Xin Hao <xhao@xxxxxxxxxxxxxxxxx>
---

Changes from v2
(https://lore.kernel.org/lkml/20220929091040.45390-1-xhao@xxxxxxxxxxxxxxxxx/)
- fix some comments suggested-by Nadav Amit <namit@xxxxxxxxxx> and
Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

arch/x86/include/asm/tlbflush.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
index cda3118f3b27..2a17698fb194 100644
--- a/arch/x86/include/asm/tlbflush.h
+++ b/arch/x86/include/asm/tlbflush.h
@@ -291,8 +291,8 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
diff &= ~_PAGE_ACCESSED;

/*
- * Did any of the 'flush_on_clear' flags was clleared set from between
- * 'oldflags' and 'newflags'?
+ * Consider the 'flush_on_clear' flags that are set on 'oldflags',
+ * Flush if any of these flags is cleared on 'newflags'.
*/
if (diff & oldflags & flush_on_clear)
return true;
--
2.31.0