Re: [PATCH] binfmt: remove taso from linux_binprm struct

From: Eric W. Biederman
Date: Thu Sep 29 2022 - 18:17:42 EST


Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> writes:

> With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> use of the special taso flag for alpha architectures in the linux_binprm
> struct is gone.
>
> Remove the definition of taso in the linux_binprm struct.
>
> No functional change.

Reviewed-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Alphas binfmt_loader is the only use I can find of that variable
so let's kill it as well.

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> ---
> Kees, please pick this patch on top of the commit above.
>
> include/linux/binfmts.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index 3dc20c4f394c..8d51f69f9f5e 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -43,9 +43,6 @@ struct linux_binprm {
> * original userspace.
> */
> point_of_no_return:1;
> -#ifdef __alpha__
> - unsigned int taso:1;
> -#endif
> struct file *executable; /* Executable to pass to the interpreter */
> struct file *interpreter;
> struct file *file;