Re: [PATCH] openrisc: update config files

[Stafford Horne]

Hi Geert,

On Thu, Sep 29, 2022 at 05:07:40PM +0200, Geert Uytterhoeven wrote:
> Hi Stafford,
> 
> On Thu, Sep 29, 2022 at 4:30 PM Stafford Horne <shorne@xxxxxxxxx> wrote:
> > On Thu, Sep 29, 2022 at 02:21:46PM +0000, Stafford Horne wrote:
> > > On Thu, Sep 29, 2022 at 12:14:58PM +0200, Lukas Bulwahn wrote:
> > > > Clean up config files by:
> > > >   - removing configs that were deleted in the past
> > > >   - removing configs not in tree and without recently pending patches
> > > >   - adding new configs that are replacements for old configs in the file
> 
> > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> > >
> > > Thanks for the patch this looks fine to me.  Usually I just generate this
> > > defcnfigs using make savedefconfig.  If there is some better way which
> > > doesn't generate the file with the # comment's I haven't found it.
> > >
> > > I will queue this.
> >
> > Actually..
> >
> > About the subject 'openrisc: update config files' and description.  Can you be
> > more specific about what updates you are making for this patch?
> >
> > For example: remove comments from config files.
> 
> These are not comments, but options that default to y or m, and
> are overriden to n by "commenting them out".
> 
> This syntax dates back to the days Kconfig was a collection of
> shell scripts. Nowadays, switching to "CONFIG_<FOO>=n" would
> perhaps make sense, as Kconfig already recognizes that syntax.

Right, I remember the *comment's* do actually are material to the config files.
In this patch not everything is removed, just old non-existent configs.

I sill prefer having a more descriptive subject.

-Stafford

> > > > --- a/arch/openrisc/configs/or1ksim_defconfig
> > > > +++ b/arch/openrisc/configs/or1ksim_defconfig
> > > > @@ -19,9 +19,6 @@ CONFIG_NET=y
> > > >  CONFIG_PACKET=y
> > > >  CONFIG_UNIX=y
> > > >  CONFIG_INET=y
> > > > -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> > > > -# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> > > > -# CONFIG_INET_XFRM_MODE_BEET is not set
> > > >  # CONFIG_INET_DIAG is not set
> > > >  CONFIG_TCP_CONG_ADVANCED=y
> > > >  # CONFIG_TCP_CONG_BIC is not set
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds