Re: [PATCH v3 5/5] iommu/s390: Fix incorrect pgsize_bitmap

From: Jason Gunthorpe
Date: Thu Sep 29 2022 - 11:59:14 EST


On Thu, Sep 29, 2022 at 05:33:02PM +0200, Niklas Schnelle wrote:
> The .pgsize_bitmap property of struct iommu_ops is not a page mask but
> rather has a bit set for each size of pages the IOMMU supports. As the
> comment correctly pointed out at this moment the code only support 4K
> pages so simply use SZ_4K here.
>
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> ---
> drivers/iommu/s390-iommu.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)

Yep!

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason