Re: [PATCH v1 2/2] dt-bindings: add bindings for QCOM flash LED

From: Krzysztof Kozlowski
Date: Thu Sep 29 2022 - 07:14:08 EST


On 29/09/2022 12:56, Fenglin Wu wrote:
>> If driver binds to only one compatible, it is expected to be the
>> fallback for all others. There might be exception for this rule but it
>> does not look like here.
>>
>>> But I was thinking to give out the PMIC names
>>> here so anyone who is using the driver could easily identify if the
>>> driver is suitable for the HW that he/she is using.
>>
>> I did not say to remove other compatibles, but to use one fallback for
>> all of them.
>>
> Do you mean to update it similar to this?
>
> compatible:
> items:
> - enum:
> - qcom,pm8150c-flash-led
> - qcom,pm8150l-flash-led
> - qcom,pm8350c-flash-led
> - const:
> - qcom,spmi-flash-led

Yes, just const is not a list, so "const: qcom,spmi-flash-led"

Best regards,
Krzysztof