Re: [PATCH 2/8] soc: mediatek: mtk-svs: improve readability of platform_probe

From: AngeloGioacchino Del Regno
Date: Thu Sep 29 2022 - 04:26:14 EST


Il 28/09/22 17:55, matthias.bgg@xxxxxxxxxx ha scritto:
From: Matthias Brugger <matthias.bgg@xxxxxxxxx>

If a compatible misses a match data entry, then something is wrong in
the development phase, we don't need to check for that at runtime.

Signed-off-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
---

drivers/soc/mediatek/mtk-svs.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index fd0f636e8644..52bb4f8bbe6d 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2332,10 +2332,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev)
int ret;
svsp_data = of_device_get_match_data(&pdev->dev);

Changing that to device_get_match_data() (so, dropping of_) would be a plus
to this cleanup, perhaps...

In any case:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

- if (!svsp_data) {
- dev_err(&pdev->dev, "no svs platform data?\n");
- return ERR_PTR(-EPERM);
- }
svsp = devm_kzalloc(&pdev->dev, sizeof(*svsp), GFP_KERNEL);
if (!svsp)