Re: [PATCH v5 2/3] dt-bindings: thermal: add loongson2k thermal binding

[Yinbo Zhu]

在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道:
> On 29/09/2022 09:07, Yinbo Zhu wrote:
> > > > > > ... and please test your patches before sending :(
> > > > You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ?
> > > > Need fix that warning, right?
> > >
> > > Yes. You said you tested it but then sent with an error... so it's not
> > > really a testing.
> > sorry, I did do some testing. but I think It is okay that can generate a
> > dtb  without reporting an error when compile yaml file, in fact, I
> > ignore the warning,  I will fix it in v6.
>
>
> Do you also send the code with warnings reported by GCC? Judging by
> number of kernel test robot reports, it could be. So just to be very,
> very clear: do not send any code which generates any warning. For GCC
> this means W=1 builds.
I don't find about the warning about GCC when compile yaml file.
and I dont't know the meaning about W=1, you said about "W=1" is to execute
following command to compile the yaml, right?

root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m
dt_binding_check W=1 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml 


I compile it use v6 patch that compile result as follows:
root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m 
dt_binding_check W=1 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml 

  DTC 
Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.example.dtb
  CHECK 
Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.example.dtb


In addtion, if you said was about loongson2_thermal.c, this code has no 
warning that I had check.

BRs,
Yinbo Zhu.

> Best regards,
> Krzysztof