Re: [PATCH v2 -next] init/Kconfig: fix unmet direct dependencies

[Lukas Bulwahn]

On Thu, Sep 29, 2022 at 9:04 AM Ren Zhijie <renzhijie2@xxxxxxxxxx> wrote:
>
> Commit 3c07bfce92a5 ("proc: make config PROC_CHILDREN depend on PROC_FS")
> make config PROC_CHILDREN depend on PROC_FS.
>
> When CONFIG_PROC_FS is not set and CONFIG_CHECKPOINT_RESTORE=y,
> make menuconfig screams like this:
>
> WARNING: unmet direct dependencies detected for PROC_CHILDREN
>   Depends on [n]: PROC_FS [=n]
>   Selected by [y]:
>   - CHECKPOINT_RESTORE [=y]
>
> CHECKPOINT_RESTORE would select PROC_CHILDREN which depends on PROC_FS,
> so add depends on PROC_FS to CHECKPOINT_RESTORE to fix this.
> Fixes: 3c07bfce92a5 ("proc: make config PROC_CHILDREN depend on PROC_FS")
> Signed-off-by: Ren Zhijie <renzhijie2@xxxxxxxxxx>
> ---
> Changes in v2:
>         - change dependency of CHECKPOINT_RESTORE to depends on PROC_FS

Thanks.

Reviewed-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>

Lukas

> ---
>  init/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index e11307310fc1..a19314933e54 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1273,6 +1273,7 @@ endif # NAMESPACES
>
>  config CHECKPOINT_RESTORE
>         bool "Checkpoint/restore support"
> +       depends on PROC_FS
>         select PROC_CHILDREN
>         select KCMP
>         default n
> --
> 2.17.1
>