Re: [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts

[Parikshit Pareek]

On Wed, Sep 21, 2022 at 08:51:32AM +0200, Johan Hovold wrote:
> On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote:
> > Create new dts file specific for Qdrive board based on sa8540p chipset.
> > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
> > Qdrive board.
> > 
> > This is quite similar to sa8295 ADP development board. Main differences
> > are related to connectors, and interface cards, like USB external ports,
> > ethernet-switch, and PCIe switch etc.
> > 
> > Signed-off-by: Parikshit Pareek <quic_ppareek@xxxxxxxxxxx>
> > Reported-by: Shazad Hussain <quic_shazhuss@xxxxxxxxxxx>
> > ---
> 
> > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> > new file mode 100644
> > index 000000000000..bd79866b80e1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> > @@ -0,0 +1,31 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2022, Linaro Limited
> > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sa8540p-adp.dtsi"
> > +
> > +/ {
> > +	model = "Qualcomm SA8540 ADP";
> > +	compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p";
> > +};
> > +
> > +&ufs_card_hc {
> > +	status = "disabled";
> > +};
> 
> What about the UFS phy, etc?
Really missed that. Will add phy nodes too.
> 
> This opt-out scheme seems quite fragile.
> 
> > +&usb_1 {
> > +	status = "disabled";
> > +};
> > +
> > +&usb_1_hsphy {
> > +	status = "disabled";
> > +};
> > +
> > +&usb_1_qmpphy {
> > +	status = "disabled";
> > +};
> 
> Johan
Regards,
Parikshit Pareek