Re: [PATCHv4 1/3] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon"

[Dinh Nguyen]

Hi,

On 9/28/22 12:15, Krzysztof Kozlowski wrote:
> On 28/09/2022 18:54, Dinh Nguyen wrote:
> > Document the optional "altr,sysmgr-syscon" binding that is used to
> > access the System Manager register that controls the SDMMC clock
> > phase.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> > ---
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +
> > +allOf:
> > +  - $ref: "synopsys-dw-mshc-common.yaml#"
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const:
> > +              - altr,socfpga-dw-mshc
>
> It still should not be an array, even if there is no warning.

I apologize, but I'm confused with the message. Do you mean it should 
not be a "const"?

Dinh