Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

From: Abhinav Kumar
Date: Wed Sep 28 2022 - 11:35:16 EST




On 9/28/2022 5:24 AM, Johan Hovold wrote:
On Tue, Sep 27, 2022 at 11:42:53AM -0700, Abhinav Kumar wrote:
On 9/27/2022 12:14 AM, Johan Hovold wrote:
On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote:
On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset sanity checks of function parameters
which have already been checked or used by the callers.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

The change LGTM, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

I think we can use below fixes tag so that we can pick up this entire
series for the fixes cycle.

Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")

Perhaps that's a requirement for drm, but I wouldn't add a Fixes tag for
this otherwise as it's not a bug.

You also have to watch out for Sasha and his autosel scripts which will
probably try to backport this to stable if it finds a Fixes tag.

Discussed with Rob on IRC, we will apply everything except the last two
patches of this series in the -fixes and take these two for the next
kernel rev push.

So the fixes go in 6.0 and the two follow-on cleanups in 6.1? Or did you
mean 6.1 and 6.2?

Johan

The fixes will go in 6.1 first.

The two follow-on cleanups in 6.2.

Thanks

Abhinav