Re: [PATCH] perf arm-spe: augment the data source type with neoverse_spe list

From: Arnaldo Carvalho de Melo
Date: Wed Sep 28 2022 - 10:20:52 EST


Em Mon, Sep 26, 2022 at 11:00:31PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 02:10:32PM +0000, Ali Saidi wrote:
> > > When synthesizing event with SPE data source, commit 4e6430cbb1a9("perf
> > > arm-spe: Use SPE data source for neoverse cores") augment the type with
> > > source information by MIDR. However, is_midr_in_range only compares the
> > > first entry in neoverse_spe.
> > >
> > > Change is_midr_in_range to is_midr_in_range_list to traverse the
> > > neoverse_spe array so that all neoverse cores synthesize event with data
> > > source packet.
> > >
> > > Fixes: 4e6430cbb1a9("perf arm-spe: Use SPE data source for neoverse cores")
> > > Signed-off-by: Jing Zhang <renyu.zj@xxxxxxxxxxxxxxxxx>
> >
> > Thanks for catching this, you're absolutely right.
> >
> > Reviewed-by: Ali Saidi <alisaidi@xxxxxxxxxx>
>
> It's also good for me:
> Reviewed-by: Leo Yan <leo.yan@xxxxxxxxxx>

Thanks, applied.

- Arnaldo