Re: [PATCH RFC SPI for-next 2/2] spi: microchip: pci1xxxx: Add suspend and resume support for PCI1XXXX SPI driver

From: Mark Brown
Date: Wed Sep 28 2022 - 07:30:29 EST


On Wed, Sep 28, 2022 at 09:13:36AM +0530, Tharun Kumar P wrote:

> + for (iter = 0; iter < spi_ptr->total_hw_instances; iter++) {
> + spi_sub_ptr = spi_ptr->spi_int[iter];
> +
> + /* Store existing config before suspend */
> + store_restore_config(spi_ptr, spi_sub_ptr, iter, 1);
> + spi_master_suspend(spi_sub_ptr->spi_host);
> + writel(reg1, spi_ptr->reg_base +
> + SPI_MST_EVENT_MASK_REG_OFFSET(iter));
> + }

This saves the register configuration before suspending the device,
meaning there may be in progress transfers changing the device while the
save is going on.

Attachment: signature.asc
Description: PGP signature