Re: [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF and MCF attribute

[Suzuki K Poulose]

On 28/09/2022 02:38, Besar Wicaksono wrote:
> > -----Original Message-----
> > From: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> > Sent: Tuesday, September 27, 2022 6:43 AM
> > To: Besar Wicaksono <bwicaksono@xxxxxxxxxx>; robin.murphy@xxxxxxx;
> > catalin.marinas@xxxxxxx; will@xxxxxxxxxx; mark.rutland@xxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > linux-tegra@xxxxxxxxxxxxxxx; sudeep.holla@xxxxxxx;
> > thanu.rangarajan@xxxxxxx; Michael.Williams@xxxxxxx; Thierry Reding
> > <treding@xxxxxxxxxx>; Jonathan Hunter <jonathanh@xxxxxxxxxx>; Vikram
> > Sethi <vsethi@xxxxxxxxxx>; mathieu.poirier@xxxxxxxxxx;
> > mike.leach@xxxxxxxxxx; leo.yan@xxxxxxxxxx
> > Subject: Re: [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF
> > and MCF attribute
> >
> > External email: Use caution opening links or attachments
> >
> >
> > On 14/08/2022 19:23, Besar Wicaksono wrote:
> > > Add support for NVIDIA System Cache Fabric (SCF) and Memory Control
> > > Fabric (MCF) PMU attributes for CoreSight PMU implementation in
> > > NVIDIA devices.
> > >
> > > Signed-off-by: Besar Wicaksono <bwicaksono@xxxxxxxxxx>

> > > +struct nv_cspmu_match {
> > > +     u32 prodid;
> > > +     u32 prodid_mask;
> > > +     u64 filter_mask;
> > > +     const char *name_pattern;
> > > +     enum nv_cspmu_name_fmt name_fmt;
> > > +     struct attribute **event_attr;
> > > +     struct attribute **format_attr;
> > > +};
> > > +
> > > +static const struct nv_cspmu_match nv_cspmu_match[] = {
> >
> > Similar coding style nit below.
>
> Sure, I will update this.
>
> > Otherwise,
> >
> > Acked-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
>
> Thanks!
>
> Unfortunately, we need to update the name of the PMUs and remove
> some of the attributes in NVIDIA implementation. This requires a change
> in nvidia_cspmu.c and nvidia-pmu.rst. I hope you are fine if I include this
> change on v5 patch.

That should be fine.

Suzuki