Re: [PATCH v3 04/11] remoteproc: mediatek: Remove redundant rproc_boot

From: TingHan Shen (沈廷翰)
Date: Wed Sep 28 2022 - 06:15:05 EST


On Wed, 2022-09-28 at 17:40 +0800, Peng Fan wrote:
>
> On 9/28/2022 4:27 PM, TingHan Shen (沈廷翰) wrote:
> > On Tue, 2022-09-27 at 13:03 +0200, AngeloGioacchino Del Regno wrote:
> > > Il 27/09/22 04:55, Tinghan Shen ha scritto:
> > > > The video codec doesn't need to explicitly boot SCP in its flow
> > > > because the SCP remote processor enables auto boot.
> > > >
> > > > The redundant usage of rproc_boot increases the number of rproc.power
> > > > over 1 and prevents successfully shutting down SCP by rproc_shutdown.
> > > >
> > > > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx>
> > >
> > > You should Cc stable on this commit, as it's a quite important fix.
> > >
> > > Regards,
> > > Angelo
> > >
> >
> > Hi Angelo,
> >
> > Ok, I'll add it at next version.
>
> If this patch is not relevant with the SCP 1 support in this patchset,
> better separate this patch out as a standalone fix.

Ok, I'll send it separately.

Regards,
TingHan

>
> Regards,
> Peng.
>
> >
> > Thanks,
> > TingHan